Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Blob index locking v2 #7572

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Fix Blob index locking v2 #7572

merged 4 commits into from
Oct 9, 2024

Conversation

LukaszRozmej
Copy link
Member

Alternative to #7568

Changes

  • Run TryGetBlobAndProof under lock, simplify to Dictionary

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@marcindsobczak marcindsobczak mentioned this pull request Oct 9, 2024
Merged
10 tasks
marcindsobczak
marcindsobczak approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@marcindsobczak marcindsobczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passing concurrency test which is failing for master #7581

@LukaszRozmej LukaszRozmej merged commit 2301867 into master Oct 9, 2024
67 checks passed
@LukaszRozmej LukaszRozmej deleted the fix/blob-index-locks-alternative branch October 9, 2024 12:05
rjnrohit pushed a commit that referenced this pull request Oct 10, 2024
@LukaszRozmej @marcindsobczak @rjnrohit
Fix Blob index locking v2 (#7572)
6129675 
Co-authored-by: Marcin Sobczak <[email protected]>
@marcindsobczak marcindsobczak mentioned this pull request Oct 10, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcindsobczak marcindsobczak marcindsobczak approved these changes

@benaadams benaadams benaadams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukaszRozmej @benaadams @marcindsobczak