Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null pointer in RecoverSignatures #7564

Merged
merged 10 commits into from
Oct 10, 2024
Merged

Fix null pointer in RecoverSignatures #7564

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
daf523e
fix
ak88 Oct 7, 2024
54cfe29
test begin
ak88 Oct 7, 2024
8f1bcd5
Merge remote-tracking branch 'origin/fix/recoversignatures' into fix/…
ak88 Oct 7, 2024
c7a4fb2
test
ak88 Oct 7, 2024
4a5e37d
cosmetic
ak88 Oct 8, 2024
bf2f007
Merge branch 'master' into fix/recoversignatures
ak88 Oct 8, 2024
d75c5c6
format
ak88 Oct 8, 2024
34eed04
remove test with wrong assumption
ak88 Oct 8, 2024
e9827e4
check auth null
ak88 Oct 10, 2024
2cb7f81
Merge branch 'master' into fix/recoversignatures
ak88 Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Nethermind/Nethermind.Consensus/Processing/RecoverSignature.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public void RecoverData(Block block)
recoverFromEcdsa++;
}

if (tx.HasAuthorizationList)
if (poolTx is not null && tx.HasAuthorizationList)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still increment recoverFromEcdsa++; ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to trigger the recovery if an authority is missing. We could add
else if(tx.AuthorizationList[i].Authority is null)
maybe?

{
for (int i = 0; i < tx.AuthorizationList.Length; i++)
{
Expand Down