-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7553 get elapsed time refactoring #7558
7553 get elapsed time refactoring #7558
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stopwatch.ElapsedMilliseconds
was long
but Stopwatch.GetElapsedTime(startTime).TotalMillisecond
is double so I expect the formatting in strings/logs will be suboptimal, can you check?
Yes, you are correct. I missed that. Have updated the changes accordingly. Pls check now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last thing: could you check if just adding N0
formatting like {X:N0}
wouldn't be better?
src/Nethermind/Nethermind.Network/P2P/Subprotocols/Eth/V66/Eth66ProtocolHandler.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.JsonRpc/WebSockets/JsonRpcSocketsClient.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.JsonRpc/WebSockets/JsonRpcSocketsClient.cs
Outdated
Show resolved
Hide resolved
Hey, I have modified the long formatting as suggested. Also, implemented the suggested changes in the code. Pls check now. |
…shubham-sonthalia/nethermind into 7553_getElapsedTime_refactoring
Resolves #7553
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, link the PR to the docs update or the issue with the details labeled
docs
. Remove if not applicable.Requires explanation in Release Notes