Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move txPool work from Processing loop event to txPool thread #7469

Merged
merged 9 commits into from
Sep 26, 2024
Merged

Move txPool work from Processing loop event to txPool thread #7469

merged 9 commits into from
Sep 26, 2024

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented Sep 21, 2024 •
edited
Loading

Changes

  • Move clearing caches to txPool processing new head rather than main processing informing txPool of new head

2.9% of archive since since its processing blocks so fast
image

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • Yes

If yes, did you write tests?

  • Yes (changed existing tests)

LukaszRozmej
LukaszRozmej approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for @marcindsobczak approval before merging

@benaadams
Copy link
Member Author

Aside this also fix JsonRpc tests timing out

marcindsobczak
marcindsobczak approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@marcindsobczak marcindsobczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, worth to run on some node/nodes and observe for a few days

@benaadams benaadams merged commit 4aa2920 into master Sep 26, 2024
66 checks passed
@benaadams benaadams deleted the txpool-off-processing branch September 26, 2024 14:06
rjnrohit pushed a commit that referenced this pull request Oct 10, 2024
@benaadams @rjnrohit
Move txPool work from Processing loop event to txPool thread (#7469)
339321f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcindsobczak marcindsobczak marcindsobczak approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benaadams @LukaszRozmej @marcindsobczak