-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tests #70
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
You need to specify the 1-3 tests you want to work on it. Only complete tests will be accepted! |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Exceptionally, we will not add tests for the cairo cheatsheet section |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Hey @julio4 is there any tests left I can work on? Maybe Constant Product AMM since OZ#953 has been fixed now. |
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedHi, I'm Nemesis Alfaro from Costa Rica, i'm a system engineer. How I plan on tackling this issueFirst, i would like carefully read the request and be in contact with you for more infomation. |
Thank you for your interest! Please take a look at the contributing guide to get started. |
Thank you for the opportunity, I will review it and if I have any questions, I will contact you |
New missing tests: |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
heyyyy @julio4 is this still available? any function to test? let me know |
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedHi my name is Jeremiah Samuel. I am a frontend and blockchain developer. I build web solutions and interested in building blockchain infrastructures. I am hardworking and focused This is my first application for contributing and would be looking forward to be granted that opportunity to gain more experience. How I plan on tackling this issueTo begin, I would await briefing on the contracts in need of unit testing. After that I would proceed to write the test, submit and wait for your review and feedback which would determine the next course of action. Your feedback is my quality assurance guiding me in the rest of the tests. |
@livinalt @EmmanuelAR and others... No need to apply on OnlyDust platform. Just explore listings and find one that have no tests, and implement tests for atleast the most important use cases. |
Thanks for the heads up @julio4. I'll check out the listings |
Most of the current listings do not have tests. Adding tests would ensure that we have not left any logic errors that could confuse readers later on.
We need to add atleast simple integration tests for all contracts. Unit tests can be added for more complex contracts.
Integration tests are tests that deploy the contract and interact with it's provided interface. They should be placed on a separate file/module
tests.cairo
.Unit tests do not have to deploy the contract and use the interface. Unit tests can use mocked implementation or state to test only one specific feature. They should be placed on the same file as the example (and hidden in the book using
ANCHOR
).You do not have to add tests to all missing listings at once.
See this as a reference.
Please open a PR per example.
The text was updated successfully, but these errors were encountered: