Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Constant Product AMM #218

Closed
julio4 opened this issue Jun 8, 2024 · 3 comments · Fixed by #252
Closed

Improvement: Constant Product AMM #218

julio4 opened this issue Jun 8, 2024 · 3 comments · Fixed by #252

Comments

@julio4
Copy link
Contributor

julio4 commented Jun 8, 2024 •
edited
Loading

Adds more explanations for the Constant Product AMM example.

Details to be Explained:

  • approve() the router to spend tokens from the user
  • How the swap function works: based on the constant product formula (x * y = k).
  • Number of shares / token ratios for add/rm liquidity. Definition of pool
@julio4 julio4 mentioned this issue Jun 8, 2024
Closed
@raizo07
Copy link
Contributor

raizo07 commented Jun 8, 2024

@julio4 I'll like to be assigned to work on this

@OkoliEvans

This comment was marked as resolved.

Sign in to view
@OkoliEvans
Copy link
Contributor

I can take this too if it's okay

@0xNeshi 0xNeshi mentioned this issue Oct 21, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expand Constant Product AMM's description 0xNeshi/StarknetByExample
3 participants
@julio4 @raizo07 @OkoliEvans