Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merkle storage handling #121

Closed
Scooletz opened this issue Aug 9, 2023 · 1 comment · Fixed by #124
Closed

Merkle storage handling #121

Scooletz opened this issue Aug 9, 2023 · 1 comment · Fixed by #124
Assignees
@Scooletz
Labels
ethereum An Ethereum specific work item that requires a good understanding of Eth 🌴Merkle Merkle construct

Comments

@Scooletz
Copy link
Contributor

Scooletz commented Aug 9, 2023 •
edited
Loading

Make the Merkle construct work for both, Storage and State. This will require some amendments in the current way it works:

  1. Make ICommit aware of the context it runs with. The Merkle should never know whether an account should be added to the key or not. Just make it work for a general Merkle tree with some keys added or deleted.
  2. Introduce a split in Block so that Merkleization for Storage can be run first and for each account separately. Then for the State
  3. Reconsider using RLP or make a change so that the Merkleization can be agnostic of what it merkleizes
  4. Provide tests for the root
@Scooletz Scooletz added this to Paprika Aug 9, 2023
@Scooletz Scooletz converted this from a draft issue Aug 9, 2023
@Scooletz Scooletz added ethereum An Ethereum specific work item that requires a good understanding of Eth 🌴Merkle Merkle construct labels Aug 9, 2023
@Scooletz Scooletz mentioned this issue Aug 9, 2023
Closed
10 tasks
@Scooletz Scooletz moved this from Todo to In Progress in Paprika Aug 10, 2023
@Scooletz Scooletz mentioned this issue Aug 14, 2023
Merged
@Scooletz Scooletz self-assigned this Aug 15, 2023
@Scooletz Scooletz mentioned this issue Aug 15, 2023
Merged
@Scooletz
Copy link
Contributor Author

Requires #126 to be finalized before it lands.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Paprika Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Scooletz Scooletz

Labels
ethereum An Ethereum specific work item that requires a good understanding of Eth 🌴Merkle Merkle construct
Projects
Paprika
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merkleization of Storage NethermindEth/Paprika
1 participant
@Scooletz