cached format string, simplified GetFormatString function

Netherlands3D · Dec 12, 2024 · f5b16d3 · f5b16d3
1 parent 143a12e
commit f5b16d3
Showing 1 changed file with 18 additions and 20 deletions.
diff --git a/Assets/Scripts/Layers/Properties/PropertyPanels/TransformPropertySection.cs b/Assets/Scripts/Layers/Properties/PropertyPanels/TransformPropertySection.cs
@@ -36,6 +36,8 @@ private class SetOfXYZ
         [SerializeField] private int scaleDecimals = 0;
         [SerializeField] private string scaleUnitCharacter = "%";
 
+        private string formatString;
+
         private const string unparseableDecimalSeparator = ",";
         private const string parseableDecimalSeparator = ".";
 
@@ -76,6 +78,11 @@ private TransformLayerPropertyData TransformPropertyData
             }
         }
 
+        private void Awake()
+        {
+            formatString = GetFormatString(scaleDecimals);
+        }
+
         private void OnEnable()
         {
             position.xField.onEndEdit.AddListener(OnPositionChanged);
@@ -217,46 +224,37 @@ private void OnScaleChanged(string axisValue)
         private void UpdatePositionFields(Coordinate coordinate)
         {
             var rdCoordinate = CoordinateConverter.ConvertTo(coordinate, CoordinateSystem.RDNAP);
-            var format = GetFormatString(positionDecimals);
 
-            position.xField.SetTextWithoutNotify($"{rdCoordinate.Points[0].ToString(format, CultureInfo.InvariantCulture)}{positionUnitCharacter}");
-            position.yField.SetTextWithoutNotify($"{rdCoordinate.Points[1].ToString(format, CultureInfo.InvariantCulture)}{positionUnitCharacter}");
-            position.zField.SetTextWithoutNotify($"{rdCoordinate.Points[2].ToString(format, CultureInfo.InvariantCulture)}{positionUnitCharacter}");
+            position.xField.SetTextWithoutNotify($"{rdCoordinate.Points[0].ToString(formatString, CultureInfo.InvariantCulture)}{positionUnitCharacter}");
+            position.yField.SetTextWithoutNotify($"{rdCoordinate.Points[1].ToString(formatString, CultureInfo.InvariantCulture)}{positionUnitCharacter}");
+            position.zField.SetTextWithoutNotify($"{rdCoordinate.Points[2].ToString(formatString, CultureInfo.InvariantCulture)}{positionUnitCharacter}");
         }
 
         private void UpdateRotationFields(Vector3 eulerAngles)
         {
-            var format = GetFormatString(rotationDecimals);
-
-            rotation.xField.SetTextWithoutNotify($"{eulerAngles.x.ToString(format, CultureInfo.InvariantCulture)}{rotationUnitCharacter}");
-            rotation.yField.SetTextWithoutNotify($"{eulerAngles.y.ToString(format, CultureInfo.InvariantCulture)}{rotationUnitCharacter}");
-            rotation.zField.SetTextWithoutNotify($"{eulerAngles.z.ToString(format, CultureInfo.InvariantCulture)}{rotationUnitCharacter}");
+            rotation.xField.SetTextWithoutNotify($"{eulerAngles.x.ToString(formatString, CultureInfo.InvariantCulture)}{rotationUnitCharacter}");
+            rotation.yField.SetTextWithoutNotify($"{eulerAngles.y.ToString(formatString, CultureInfo.InvariantCulture)}{rotationUnitCharacter}");
+            rotation.zField.SetTextWithoutNotify($"{eulerAngles.z.ToString(formatString, CultureInfo.InvariantCulture)}{rotationUnitCharacter}");
         }
 
         private void UpdateScalingFields(Vector3 localScale)
         {
             var xPercentage = localScale.x * scaleMultiplier;
             var yPercentage = localScale.y * scaleMultiplier;
             var zPercentage = localScale.z * scaleMultiplier;
-            var format = GetFormatString(scaleDecimals);
 
-            scale.xField.SetTextWithoutNotify($"{xPercentage.ToString(format, CultureInfo.InvariantCulture)}{scaleUnitCharacter}");
-            scale.yField.SetTextWithoutNotify($"{yPercentage.ToString(format, CultureInfo.InvariantCulture)}{scaleUnitCharacter}");
-            scale.zField.SetTextWithoutNotify($"{zPercentage.ToString(format, CultureInfo.InvariantCulture)}{scaleUnitCharacter}");
+            scale.xField.SetTextWithoutNotify($"{xPercentage.ToString(formatString, CultureInfo.InvariantCulture)}{scaleUnitCharacter}");
+            scale.yField.SetTextWithoutNotify($"{yPercentage.ToString(formatString, CultureInfo.InvariantCulture)}{scaleUnitCharacter}");
+            scale.zField.SetTextWithoutNotify($"{zPercentage.ToString(formatString, CultureInfo.InvariantCulture)}{scaleUnitCharacter}");
         }
 
         private static string GetFormatString(int decimals)
         {
             if (decimals == 0)
                 return "0";
 
-            string format = "0.";
-            for (int i = 0; i < decimals; i++)
-            {
-                format += '0';
-            }
-
-            return format;
+            string zeros = new string('0', decimals);
+            return $"0.{zeros}";
         }
     }
 }