-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on guava #288
Comments
Provided the Guava classes are not part of the public API you could shade guava into servo-core, I'm not sure if you mind the bloat though (also not sure offhand what tool Gradle uses to do this, looks like fatJar or maybe this port of maven shade - https://github.com/johnrengelman/shadow) |
There are a couple of instances where we expose guava classes in the public API: for example DoubleGauge and MetricTransformObserver. Shading is an option, but it's easy enough to remove the dependency (other than how to deal with the public API). I have a simple branch where I'm doing a quick pass at this: https://github.com/dmuino/servo/tree/guavaCleanup |
No plans to change the public api for servo at this time. |
Ideally servo shouldn't depend on guava. This would only leave slf4j as a runtime dependency which is quite OK.
The text was updated successfully, but these errors were encountered: