Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on guava #288

Closed
dmuino opened this issue Dec 1, 2014 · 3 comments
Closed

Remove dependency on guava #288

dmuino opened this issue Dec 1, 2014 · 3 comments

Comments

@dmuino
Copy link
Contributor

dmuino commented Dec 1, 2014

Ideally servo shouldn't depend on guava. This would only leave slf4j as a runtime dependency which is quite OK.

@ryanrupp
Copy link
Contributor

ryanrupp commented Dec 2, 2014

Provided the Guava classes are not part of the public API you could shade guava into servo-core, I'm not sure if you mind the bloat though (also not sure offhand what tool Gradle uses to do this, looks like fatJar or maybe this port of maven shade - https://github.com/johnrengelman/shadow)

@dmuino
Copy link
Contributor Author

dmuino commented Dec 2, 2014

There are a couple of instances where we expose guava classes in the public API: for example DoubleGauge and MetricTransformObserver.

Shading is an option, but it's easy enough to remove the dependency (other than how to deal with the public API). I have a simple branch where I'm doing a quick pass at this: https://github.com/dmuino/servo/tree/guavaCleanup

@dmuino dmuino mentioned this issue Dec 5, 2014
@brharrington
Copy link
Contributor

No plans to change the public api for servo at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants