Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The releaseYear fields are not zig-zag encoded in memlayout-object.png #674

Open
clay-mayers opened this issue Mar 28, 2024 · 0 comments
Open

Comments

@clay-mayers
Copy link

As an example, Ordinal 0 shows 0b11111001111 (0x7cf/1999) when it should be 2x larger (0xf9e) 0b111110011110. Fixing requires making the field size for releaseYear and object size 1 bit larger (12 and 22). As is, the release year would be -999.

The bitmap is pressed for space as it is. Maybe all that's required is to adjust the text in advanced-topics.md to call out that the example doesn't show the releaseYear as zig-zag encoded.

The id also doesn't seem to be zig-zag encoded (assuming negative IDs were not intentional).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant