Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct way to return path item not found? #208

Open
eddieajau opened this issue Feb 8, 2017 · 0 comments
Open

Correct way to return path item not found? #208

eddieajau opened this issue Feb 8, 2017 · 0 comments

Comments

@eddieajau
Copy link

I'm looking at the falcor-router-demo and it looks like it is suggesting that if a resource is not found, you return a path value of undefined.

  results.push({
    path: ['titlesById', titleId],
    value: undefined
  });

However, in cache/pathValueMerge.js, we've got:

 else if ((pathValue.value !== null) && (pathValue.value.$type === $ref)) {

Am I right in assuming that I should return null, not undefined if the path is not found?

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant