Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to understand part of windowed algorithm #152

Open
IgorPerikov opened this issue Dec 3, 2019 · 1 comment
Open

Trying to understand part of windowed algorithm #152

IgorPerikov opened this issue Dec 3, 2019 · 1 comment

Comments

@IgorPerikov
Copy link
Contributor

I'm trying to figure out, why (and does it?) this condition check for windowed limit is important https://github.com/Netflix/concurrency-limits/blob/master/concurrency-limits-core/src/main/java/com/netflix/concurrency/limits/limit/WindowedLimit.java#L155

It looks like under low load it wouldn't let the delegate limit to perform (while it probably should raise limit, especially if it was pessimisized before on overload)
And under high load it will work fine with averages, but with percentiles - you're either skipping too many samples(because they exceed window size) or letting actual logic not to be executed, because you will be setting window size to a big number. So picking window size became really tricky and hard to achieve properly

@IgorPerikov IgorPerikov changed the title Trying understanding part of windowed algorithm Trying to understand part of windowed algorithm Dec 3, 2019
@jhalterman
Copy link

The PR that added this check briefly mentions the rationale: #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants