Adding utility functions for observables of strings useful for processing non blocking IO. #516
Conversation
|
RxJava-pull-requests #441 SUCCESS |
|
RxJava-pull-requests #442 SUCCESS |
|
RxJava-pull-requests #451 FAILURE |
|
Looking at this more this seems to fit better as a contrib module. Nowhere else in RxJava do we have utility classes for doing specific types of data manipulation. Once we have String manipulation we'll open the door for all kinds of others. Similar to how Swing and Android utilities are in a separate jar, should we have a data-transformations contrib module where this stuff goes? |
|
There are these four that operate on Observables of numbers. rx.Observable.sum(Observable) |
|
The various aggregation operators like sum are unfortunately monomorphic because Java (and .NET) lack a type like Scala's http://www.scala-lang.org/api/current/index.html#scala.math.Numeric. However, if you squint your eyes, the various aggregates are generics. I agree with Ben that it is best to keep the core as polymorphic and tight as possible, that is operators on Observable where T is a set of types > 1 and have a (hopefully) thriving ecosystem of "domain specific" operations to a contrib module. There are a couple of tricks that we can pull to still allow for a fluent coding style. |
|
I wasn't trying to highlight how monomorphic aspect but that It seems inconsistent to the accumulation of java.lang.Number (sum) to exist in the core but not the accumulation of java.lang.String (concat) to also be part of the core. I'll rejigger the PR to put it in a new module so this can be closed. |
|
RxJava-pull-requests #455 FAILURE |
| import rx.util.functions.Func1; | ||
| import rx.util.functions.Func2; | ||
|
|
||
| public class AssertObservable { |
There was a problem hiding this comment.
This is still inside core and is solely used for testing. Perhaps if it's in core and for testing it should be in the /src/test/ folder?
If it's intended for use in production code then perhaps another contrib module for testing capabilities?
|
Much better ... just a question on the |
|
RxJava-pull-requests #469 FAILURE |
|
RxJava-pull-requests #470 FAILURE |
|
RxJava-pull-requests #471 SUCCESS |
Adding utility functions for observables of strings useful for processing non blocking IO.
Adding utility functions for observables of strings useful for processing non blocking IO.
I started developing this for use with the rxjava-apache-http contrib module to safely and scalable decode infinite observables of byte arrays into strings but thought it should live in core because it could be useful for non blocking disk IO.
I did not make this part of rx.Observable because these operators only work on observables of string. The drawback is that discoverability will be harder.