Implemented the 'Amb' operator #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #379 FAILURE |
|
You shouldn't define a vararg method taking a generic type, because you cannot use it without getting warnings (we've already had this with other operators). Instead, define an overload for 2 args, 3 args, 4 args, ... |
|
Yup, it's a pain, but this is what we ended up doing for zip, merge, etc instead of using varargs. |
|
RxJava-pull-requests #382 FAILURE |
benjchristensen
added a commit
that referenced
this pull request
Nov 5, 2013
Merge Amb Operator in PR #460
|
Thank you |
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
Merge Amb Operator in PR ReactiveX#460
benjchristensen
added a commit
to ReactiveX/RxScala
that referenced
this pull request
Aug 19, 2014
Merge Amb Operator in PR ReactiveX/RxJava#460
benjchristensen
added a commit
to ReactiveX/RxScala
that referenced
this pull request
Aug 19, 2014
Merge Amb Operator in PR ReactiveX/RxJava#460
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR implemented the
Amboperator #22. I used varargs to support the array version and first-second version in one method. So in my PR, there are only two variants.