[rxjava-android] OperationObserveFromAndroidComponent

[mttkay]

This is in reference to https://github.com/soundcloud/RxJava/issues/1

Android applications can use this operator to safely observe a source sequence on the main user interface thread. As long as the subscription is unsubscribed from in onDestroy or onDetach, no resource leaks will occur.

I have also added an AndroidObservable class which acts as an entry point for instantiating Android specific observer instances.

[cloudbees-pull-request-builder]

RxJava-pull-requests #377 FAILURE
Looks like there's a problem with this pull request

[mttkay]

The build failed with an OOM while compiling the Scala module. Might just be a configuration issue.

[benjchristensen]

Regarding CloudBees ... I've been trying to increment the memory high enough to get builds working ... still no luck. I may need to get CloudBees support to help.

[gyulavoros]

@mttkay Would it make sense, to change OnSubscribeBase<T, AndroidComponent>.isComponentValid() implementation to return !activity.isFinishing() in case of an Activity? I can send a pull request if you confirm.

[mttkay]

Hi,

we used to have this but decided it doesn't make sense. You might find more
information in the GH issue history.

IIRC the reason was that since the client needs to unsubscribe in
onDestroy anyway, and since isFinishing is only meaningful during
onPause, it doesn't really add any value to have this check. It's pretty
obvious that you're finishing the activity if onDestroy is called, and as
long as you call unsubscribe in onDestroy, all is good.

On Mon, Nov 4, 2013 at 11:45 AM, Vörös Gyula [email protected]:

@mttkay https://github.com/mttkay Would it make sense, to change
OnSubscribeBase.isComponentValid() implementation to return
!activity.isFinishing() in case of an Activity? I can send a pull request
if you confirm.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/458#issuecomment-27676781
.