Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin Language Adaptor #438

Merged
merged 10 commits into from
Oct 17, 2013
Merged

Conversation

MarioAriasC
Copy link
Contributor

Kotlin could be used with RxJava without language adaptors.

This language adaptor just provide a set of extension functions to enable a more idiomatic usage.

There are two test classes:

  • BasicKotlinTest is just plain Kotlin
  • ExtensionTest is Kotlin with the extensions provided by this adaptor

@cloudbees-pull-request-builder

RxJava-pull-requests #350 FAILURE
Looks like there's a problem with this pull request

@MarioAriasC
Copy link
Contributor Author

This task is failing

`:language-adaptors:rxjava-scala:compileScala FAILED``

Not related with my Pull Request

@samuelgruetter
Copy link
Contributor

It's not related to Scala either, but the problem is that the jvm ran out of perm gen memory. Increasing -XX:MaxPermSize should solve the problem, but I'm not sure if this can be done in the gradle files or if it needs changes in the cloudbees config.

@karansinghkjs346
Copy link

hello ,

any one can help me i am new to github and i want to contribute as i am proficient in java and i can see this project is going with my skills ,please tell me how to start i dont knw anything how to help so please can anyone guide me

thank you :)

@benjchristensen
Copy link
Member

Thank you @MarioAriasC for the pull request! This is great to have another language added.

I'll try and get the CloudBees build issue resolved, review the structure of the pull request and then merge and release.

benjchristensen added a commit that referenced this pull request Oct 17, 2013
@benjchristensen benjchristensen merged commit 7e1a9a7 into ReactiveX:master Oct 17, 2013
@samuelgruetter
Copy link
Contributor

@benjchristensen still the same issue on CloudBees, could you please have a look? Should not be too hard according to https://wiki.jenkins-ci.org/display/JENKINS/Builds+failing+with+OutOfMemoryErrors

@benjchristensen
Copy link
Member

@samuelgruetter I had increased the PermGen size and it started working for a bit then is failing again so apparently we pushed past the limit I set yet again. I'll try another time.

rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
…eX#438)

Issue ReactiveX#273: Added remove method to AbstractRegistry.
Issue ReactiveX#273: Added replace method to AbstractRegistry.
Issue ReactiveX#327: MicroMeter tagged Metric classes are automatically updated when an entry is added, removed or replaced in AbstractRegistry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants