Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull 267 - Merge combineLatest #303

Merged
merged 10 commits into from
Jul 5, 2013
Merged

Pull 267 - Merge combineLatest #303

merged 10 commits into from
Jul 5, 2013
+125 −96

Conversation

benjchristensen
Copy link
Member

Spent some time reviewing it and it seems good. Any bugs can be dealt with as people start playing with it instead of me holding this up as a pull request any longer since this exposes combineLatest in Observable for I believe the first time and is thus a low risk to breaking any existing users.

jmhofer and others added 10 commits April 6, 2013 13:38
avoiding some synchronization on combineLatest
eb5df87
Merge branch 'master' into combineLatest
fc99abe
Merge branch 'master' into combineLatest
7ce53f0
handled combine functions that throw exceptions and added a test agai…
4250d27 
…nst this case
added combineLatest static methods to Observable
bb39cac
Got rid of the last remnants of synchronization in favor of a concurr…
ba41db1 
…ent map.
Fixed a javadoc parameter.
d5259ca
improved generics for combineLatest (PECS principle)
1500859
Tried to adapt according to Ben's review comments.
797bf4d
@benjchristensen
Merge branch 'combineLatest' of git://github.com/jmhofer/RxJava into …
c88f36e 
…pull-267-combineLatest

Conflicts:
	rxjava-core/src/main/java/rx/Observable.java
	rxjava-core/src/main/java/rx/operators/OperationCombineLatest.java
benjchristensen added a commit that referenced this pull request Jul 5, 2013
@benjchristensen
Merge pull request #303 from benjchristensen/pull-267-combineLatest
a2404bf 
Pull 267 - Merge combineLatest
@benjchristensen benjchristensen merged commit a2404bf into ReactiveX:master Jul 5, 2013
@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #173 SUCCESS
This pull request looks good

@mttkay
Copy link
Contributor

mttkay commented Jul 20, 2013

I noticed there is no marble diagram in the documentation, I find these extremely helpful to understand how an operator works. Is combineLatest different from zip only in how events are timed? It looks like it accomplishes something very similar.

@jmhofer
Copy link
Contributor

jmhofer commented Jul 20, 2013

It's different in that it doesn't keep the sources "synced". How do you create those diagrams? I'd draw one if I knew how...

@DavidMGross
Copy link
Collaborator

There's a marble diagram for combineLatest at:
https://github.com/Netflix/RxJava/wiki/Combining-Observables#combinelatest
and it should also be in the javadocs as of the next release.

On Sat, Jul 20, 2013 at 1:37 AM, Joachim Hofer [email protected]:

It's different in that it doesn't keep the sources "synced". How do you
create those diagrams? I'd draw one if I knew how...

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/303#issuecomment-21290348
.

@mttkay
Copy link
Contributor

mttkay commented Jul 22, 2013

Thanks, that clarifies it a lot!

rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
@benjchristensen
Merge pull request ReactiveX#303 from benjchristensen/pull-267-combin…
f047210 
…eLatest

Pull 267 - Merge combineLatest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benjchristensen @cloudbees-pull-request-builder @mttkay @jmhofer @DavidMGross