-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swing scheduler #254
Swing scheduler #254
Conversation
yet fast enough...
moved `SwingScheduler` into a new subproject `rxjava-swing`.
RxJava-pull-requests #115 FAILURE |
The failing test on Cloudbees says that the test should probably use longer delays... |
RxJava-pull-requests #116 FAILURE |
I'm not the only one who used too short delays in the tests. ;) |
This is a good addition - I imagine we'll also end up with something like On Hystrix I called it We could go with:
None of these affects the Maven Central published name though, so it's just the organization of the code. This module in /extensions/rxjava-swing will be published as |
For the test delays I've started to try and use When specifically testing a scheduler though it can be tricky sometimes to do it this way :-) |
I vote for rxjava-contrib if only to be consistent with hystrix. Also Dave On Thu, May 2, 2013 at 9:01 AM, Ben Christensen [email protected]:
|
I'm good with rxjava-contrib, too. |
I'm also okay with Do you want to make the change @jmhofer, or do you want me to do it as a custom merge? |
I can do it, give me an hour, not at my computer right now. |
RxJava-pull-requests #117 SUCCESS |
Swing scheduler
…actory-methods Additional factory methods - issue ReactiveX#249
I've added a Swing-specific scheduler to RxJava. However, it probably doesn't belong to
rxjava-core
and therefore, I've created a subfolder namedextensions
with currently one single subprojectrxjava-swing
with currently one single classSwingScheduler
.I've tried to create a build for this, too, but I'm not very familiar with Gradle, so somebody should probably check that it's okay like this.
Also, I'm not very happy with the subfolder name (
extensions
). Maybe somebody has a better idea for a more specific name?