Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of AsyncSubject #250

Merged
merged 1 commit into from
May 1, 2013
Merged

Initial implementation of AsyncSubject #250

merged 1 commit into from
May 1, 2013

Conversation

michaeldejong
Copy link
Contributor

I've done some work on AsyncSubject, including unit tests and I'm looking for feedback.

I don't expect to get this pull request immediately accepted. But I hope to find out if this is the correct workflow for this repository, and if the code is up to your standards, before I start pouring in more hours into issue #17. If you guys are ok with the AsyncSubject implementation I'll start working on the others.

Looking forward to some feedback!

@cloudbees-pull-request-builder

RxJava-pull-requests #110 SUCCESS
This pull request looks good

@benjchristensen
Copy link
Member

Hi @michaeldejong, thanks for getting involved!

Based on my reading of the MSDN docs for AsyncSubject and your code this looks good.

Thank for you following the coding style of the project and making sure the copyright, unit tests etc are all in place.

Merging now ...

benjchristensen added a commit that referenced this pull request May 1, 2013
@benjchristensen benjchristensen merged commit 7b233d8 into ReactiveX:master May 1, 2013
rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
…ations

Initial implementation of AsyncSubject
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants