Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operator: Last #57

Closed
benjchristensen opened this issue Jan 18, 2013 · 2 comments
Closed

Operator: Last #57

benjchristensen opened this issue Jan 18, 2013 · 2 comments
Labels
Enhancement
Milestone
Road to 1.0

Comments

@benjchristensen
Copy link
Member

There is already a "last" operator but Rx includes another overload:

http://msdn.microsoft.com/en-us/library/hh229203(v=vs.103).aspx
@benjchristensen
Copy link
Member Author

So it appears our last() implementation is wrong and returns Observable whereas the MSDN docs show it to be blocking: http://msdn.microsoft.com/en-us/library/hh229056(v=vs.103).aspx.

This will be a breaking change to 0.5.x but needs to be done to conform to the Rx contract.

TakeLast is the correct non-blocking operator: #85

@benjchristensen benjchristensen mentioned this issue Feb 28, 2013
Merged
@mairbek mairbek mentioned this issue Mar 4, 2013
Merged
@benjchristensen
Copy link
Member Author

Completed in #184 and will be released as a breaking change in 0.6.0

rickbw pushed a commit to rickbw/RxJava that referenced this issue Jan 9, 2014
@benjchristensen
Convert 'last' from non-blocking to blocking to match Rx.Net
f7d5766 
See ReactiveX#57 (comment) for background.

NOTE: This is a breaking change thus we are bumping the version from 0.5.x to 0.6.x

Manual merge of branch 'last' of git://github.com/mairbek/RxJava into issue-57-last

Conflicts:
	rxjava-core/src/main/java/rx/Observable.java
zsxwing pushed a commit to zsxwing/RxScala that referenced this issue Aug 19, 2014
@benjchristensen
Convert 'last' from non-blocking to blocking to match Rx.Net
c6fd673 
See ReactiveX/RxJava#57 (comment) for background.

NOTE: This is a breaking change thus we are bumping the version from 0.5.x to 0.6.x

Manual merge of branch 'last' of git://github.com/mairbek/RxJava into issue-57-last

Conflicts:
	rxjava-core/src/main/java/rx/Observable.java
benjchristensen added a commit to ReactiveX/RxScala that referenced this issue Aug 19, 2014
@benjchristensen
Convert 'last' from non-blocking to blocking to match Rx.Net
96d031a 
See ReactiveX/RxJava#57 (comment) for background.

NOTE: This is a breaking change thus we are bumping the version from 0.5.x to 0.6.x

Manual merge of branch 'last' of git://github.com/mairbek/RxJava into issue-57-last

Conflicts:
	rxjava-core/src/main/java/rx/Observable.java
benjchristensen added a commit to ReactiveX/RxScala that referenced this issue Aug 19, 2014
@benjchristensen
Convert 'last' from non-blocking to blocking to match Rx.Net
638b26a 
See ReactiveX/RxJava#57 (comment) for background.

NOTE: This is a breaking change thus we are bumping the version from 0.5.x to 0.6.x

Manual merge of branch 'last' of git://github.com/mairbek/RxJava into issue-57-last

Conflicts:
	rxjava-core/src/main/java/rx/Observable.java
benjchristensen added a commit to ReactiveX/RxScala that referenced this issue Aug 19, 2014
@benjchristensen
Convert 'last' from non-blocking to blocking to match Rx.Net
be67385 
See ReactiveX/RxJava#57 (comment) for background.

NOTE: This is a breaking change thus we are bumping the version from 0.5.x to 0.6.x

Manual merge of branch 'last' of git://github.com/mairbek/RxJava into issue-57-last

Conflicts:
	rxjava-core/src/main/java/rx/Observable.java
benjchristensen added a commit to ReactiveX/RxJRuby that referenced this issue Aug 19, 2014
@benjchristensen
Convert 'last' from non-blocking to blocking to match Rx.Net
01f61df 
See ReactiveX/RxJava#57 (comment) for background.

NOTE: This is a breaking change thus we are bumping the version from 0.5.x to 0.6.x

Manual merge of branch 'last' of git://github.com/mairbek/RxJava into issue-57-last

Conflicts:
	rxjava-core/src/main/java/rx/Observable.java
benjchristensen added a commit to ReactiveX/RxGroovy that referenced this issue Aug 19, 2014
@benjchristensen
Convert 'last' from non-blocking to blocking to match Rx.Net
96f2628 
See ReactiveX/RxJava#57 (comment) for background.

NOTE: This is a breaking change thus we are bumping the version from 0.5.x to 0.6.x

Manual merge of branch 'last' of git://github.com/mairbek/RxJava into issue-57-last

Conflicts:
	rxjava-core/src/main/java/rx/Observable.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
Road to 1.0
Development

No branches or pull requests
1 participant
@benjchristensen