-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove specific workarounds for Visual Studio 2017 #378
Comments
+1 to support only VS2019, please don't waste time just because it's (it was, actually) a problem for me to update to newer visual studio versions |
Tests run on .NET Core 2.2 (a, b, c), because VS2017 doesn't properly support 3.0+ of the .NET Core SDK. Because of this, our Travis-CI config has to install the runtime separately (admittedly, I kinda think the built-in activities should let us give it arrays of SDK and runtime versions to install, but whatever). We also can't directly do this in the GitHub Action for setting up .NET Core (actions/setup-dotnet#25). |
Cool -- @FObermaier does VS2019 work for you? If so, I can push some updates soon. |
In #337, @DGuidi mentioned that he's using Visual Studio 2017, so there have been a few places here and there where I've gone out of my way to avoid knowingly breaking that.
At some point, though, it's going to be too much. e.g., we need to pick one of the following:
#if
conditional compilation to get both of the aboveSo this issue has two purposes:
The text was updated successfully, but these errors were encountered: