Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove specific workarounds for Visual Studio 2017 #378

Closed
airbreather opened this issue Jan 14, 2020 · 4 comments
Closed

Remove specific workarounds for Visual Studio 2017 #378

airbreather opened this issue Jan 14, 2020 · 4 comments

Comments

@airbreather
Copy link
Member

In #337, @DGuidi mentioned that he's using Visual Studio 2017, so there have been a few places here and there where I've gone out of my way to avoid knowingly breaking that.

At some point, though, it's going to be too much. e.g., we need to pick one of the following:

So this issue has two purposes:

  1. Document the things that we could do differently if we dropped VS2017 support
  2. Track who still needs VS2017 support
@DGuidi
Copy link
Contributor

DGuidi commented Jan 14, 2020

+1 to support only VS2019, please don't waste time just because it's (it was, actually) a problem for me to update to newer visual studio versions

@airbreather
Copy link
Member Author

Document the things that we could do differently if we dropped VS2017 support

Tests run on .NET Core 2.2 (a, b, c), because VS2017 doesn't properly support 3.0+ of the .NET Core SDK.

Because of this, our Travis-CI config has to install the runtime separately (admittedly, I kinda think the built-in activities should let us give it arrays of SDK and runtime versions to install, but whatever).

We also can't directly do this in the GitHub Action for setting up .NET Core (actions/setup-dotnet#25).

@airbreather
Copy link
Member Author

Document the things that we could do differently if we dropped VS2017 support

VS2017 limits the C# language version we can use: no higher than 7.3.

C# 8.0 is required for #369.

@airbreather
Copy link
Member Author

+1 to support only VS2019, please don't waste time just because it's (it was, actually) a problem for me to update to newer visual studio versions

Cool -- @FObermaier does VS2019 work for you? If so, I can push some updates soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants