Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The latest nksip (v0.6.1) along with nkpacket (from master) doesn't provide certificates during tls handshake #9

Open
pickme467 opened this issue Oct 5, 2020 · 0 comments

Comments

@pickme467
Copy link

pickme467 commented Oct 5, 2020

It looks like configuration map stored in ets table doesn't have tls_keyfile, tls_certfile nor tls_cacertfile elements. As a result the ssl:connect is invoked without certificates because nkpacket_tls:make_outbound_opts is unable to retrieve them from registered record. I am not sure where exactly it is removed. I looked at nkpacket_transport_tcp:init where configuration is inserted into the ets table. The mechanism doesn't include tls specific keys, but the whole algorithm looks the same as for v0.6.1 version and this version seems to work.

It seems that the version v0.5.0 of nksip also doesn't have this working. A solution would be to extend ConnMetaOpts variable used in nkpacket_transport_tcp:init with the following elements:
ConnMetaOpts = [tcp_packet, tls_certfile, tls_keyfile, tls_cacertfile, tls_verify | ?CONN_LISTEN_OPTS],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant