Add support for Sony BRAVIA #141
Conversation
|
Thanks for your contribution! To clarify, the TV does use Android TV but also has it's own separate API? Do these commands also work within it's Android TV interface and/or are for it's non Android TV UI components? |
|
Also please change the target branch to |
Clarified in #141 (comment) |
|
@Nerwyn I believe I've implemented all the feedback we've discussed, thanks for your review! I've added some more default sources and validated the Netflix button works as expected. Let me know if you want anything else. Otherwise thank you for your time on this, it helped me out and the API for adding a new TV model was super easy. Keep up the good work! Thanks! |
| }, | ||
| }, | ||
| icon: 'mdi:youtube', | ||
| }, // Past this object is untested sources. |
There was a problem hiding this comment.
The default source list should be alphabetical, since it uses the order in this file to display the default sources in the layout tab. While I could sort/alphabetize this in the UI editor code, I want to keep it alphabetized here for organization and ease of lookup purposes. You can just mark the untested sources with // UNTESTED
| icon: 'mdi:waveform', | ||
| }, | ||
| { | ||
| type: 'button', |
There was a problem hiding this comment.
While this does have a remote command, Netflix is really a source and should be in the other list.
| @@ -3,13 +3,14 @@ export const KeyboardPlatforms = [ | |||
| 'Fire TV', | |||
| 'Roku', | |||
| 'Kodi', | |||
| 'Sony BRAVIA' | |||
There was a problem hiding this comment.
Since Sony BRAVIA is a keyboard platform, it should also be added to the switch cases in keyboard-dialog.ts as well. Android TV uses a mix of ADB and the Android TV remote API, and Fire TV uses purely ADB. Can you add it to the appropriate cases? I imagine it needs purely ADB (Fire TV) but you should do some tests.
|
@alex4108 have you had a chance to look at the additional feedback? |
|
@alex4108 can you try the 4.2.0 alpha? I resolved the merge conflicts and made the final fixes so the Sony BRAVIA platform should be working now. |
|
@Nerwyn with 4.2.0-alpha.001 installed by HACS I can confirm my BRAVIA card continues to work as it did on my fork! Thanks! |
|
Great! I'm working on implementing another feature for 4.2, so it'll be a few days until this is officially released. |
Basing off the bravia integration, commands here vary compared to traditional ADB provided integration.
I took some time to write up some sources and keys against the bravia integration as listed above, using my KD-55X750H. I was able to confirm that Keyboard via ADB works here too