Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add renderTop element, corresponding to renderBottom #9365

Merged
merged 4 commits into from
May 26, 2021
Merged

feat: add renderTop element, corresponding to renderBottom #9365

merged 4 commits into from
May 26, 2021

Conversation

robinslee
Copy link
Contributor

@robinslee robinslee commented May 20, 2021 •
edited
Loading

这个 PR 做了什么? (简要描述所做更改)

为virtual-list的前部添加一个非回收区域，与之相对的是 renderBottom 属性

参考微信小程序的recycle-view组件中的 before slot 微信相关文档

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

@robinslee
Copy link
Contributor Author

cc @Chen-jj @ZakaryCode @luckyadam

@taro-bot2 taro-bot2 bot mentioned this pull request May 22, 2021
Closed
@luckyadam luckyadam merged commit 6cb81bf into NervJS:next May 26, 2021
@taro-bot2 taro-bot2 bot mentioned this pull request May 29, 2021
Closed
@hellohejinyu
Copy link

renderTop 估计不能简单的和 renderBottom 一样来添加，我看源代码里面没有考虑 top 区域的高度，导致虚拟渲染的高度计算有问题，顶部区域会过早的被回收。
image

@hellohejinyu
Copy link

image 这是我的 `renderTop`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luckyadam luckyadam luckyadam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robinslee @hellohejinyu @luckyadam