fix(@tarojs/extend): query 判空&抛出异常 #9328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luckyadam 能review下吗，很小的点，还没能合并上去 |
|
@Chen-jj review please. |
Chen-jj
requested changes
Jul 8, 2021
| @@ -711,8 +711,9 @@ export const Zepto = (function () { | |||
| if (!this.length) return null | |||
| if (document.documentElement !== this[0] && !$.contains(document.documentElement, this[0])) { return { top: 0, left: 0 } } | |||
| if (!isBrowser) { | |||
| return new Promise((resolve) => { | |||
| return new Promise((resolve, reject) => { | |||
| Taro.createSelectorQuery().select('#' + this[0].uid).boundingClientRect(function (rect) { | |||
There was a problem hiding this comment.
boundingClientRect 的回调要用箭头函数
Chen-jj
requested changes
Jul 8, 2021
| Taro.createSelectorQuery().select('#' + this[0].uid).boundingClientRect(function (rect) { | ||
| if (!rect) reject(new Error('offset error: ' + '#' + this[0].uid + ' query fail')) |
There was a problem hiding this comment.
应该直接 return，或者把 resolve 放入 else 块中。现在还是会执行 resolve 的。
There was a problem hiding this comment.
Promise A+ 规范会处理reject后的resolve
|
@alexlees 十分抱歉现在才 review。PR 有两个问题，因为时间久远所有我们来改吧，十分感谢 PR ～ |
17 tasks
OK，抱歉，被关掉MR后还是有点抱怨，但是看到晚上11点还在为开源做事情还是很感动 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
对createSelectorQuery 做判空，并在错误时抛出异常
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: