Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(taro-h5): chooseImage 支持 sourceType #8815

Merged
merged 4 commits into from
Apr 6, 2022
Merged

fix(taro-h5): chooseImage 支持 sourceType #8815

merged 4 commits into from
Apr 6, 2022

Conversation

liuchuzhang
Copy link
Contributor

@liuchuzhang liuchuzhang commented Mar 5, 2021 •
edited
Loading

这个 PR 做了什么? (简要描述所做更改)

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用，不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

其它需要 Reviewer 或社区知晓的内容：
同步 #6101 代码

@liuchuzhang liuchuzhang force-pushed the pr/fix-choose-image branch from fadfd28 to 9d02b8f Compare March 5, 2021 02:54
@taro-bot2 taro-bot2 bot mentioned this pull request Mar 6, 2021
Closed
@liuchuzhang liuchuzhang closed this Mar 8, 2021
@tourze
Copy link
Contributor

tourze commented Mar 9, 2021

好特性，求合并

@liuchuzhang
Copy link
Contributor Author

求同步到 next 分支 @Chen-jj

@liuchuzhang liuchuzhang reopened this Mar 31, 2022
@liuchuzhang liuchuzhang force-pushed the pr/fix-choose-image branch from 9d02b8f to a244386 Compare March 31, 2022 10:36
@liuchuzhang
Copy link
Contributor Author

reopen 了

@taro-bot2 taro-bot2 bot mentioned this pull request Apr 2, 2022
Closed
@ZakaryCode ZakaryCode added A-api Area - H5 API 相关 T-h5 Target - 编译到 H5 labels Apr 6, 2022
ZakaryCode
ZakaryCode approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@ZakaryCode ZakaryCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZakaryCode ZakaryCode merged commit 9e43aca into NervJS:next Apr 6, 2022
@liuchuzhang liuchuzhang deleted the pr/fix-choose-image branch April 7, 2022 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZakaryCode ZakaryCode ZakaryCode approved these changes

Assignees
No one assigned
Labels
A-api Area - H5 API 相关 T-h5 Target - 编译到 H5
Projects
H5
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuchuzhang @tourze @ZakaryCode