Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(virtual-list): scrollTo 调用后会额外触发一次 render，并导致 scrollView 回到顶部(#8560) #8562

Merged
merged 2 commits into from
Feb 10, 2021
Merged

fix(virtual-list): scrollTo 调用后会额外触发一次 render，并导致 scrollView 回到顶部(#8560) #8562

merged 2 commits into from
Feb 10, 2021

Conversation

GitaiQAQ
Copy link
Contributor

@GitaiQAQ GitaiQAQ commented Jan 21, 2021 •
edited
Loading

这个 PR 做了什么? (简要描述所做更改)
在 createListComponent 增加 lockedScrollOffset 来提供一个稳定的 scrollOffset

来解决 rerender 产生的回滚

这个 PR 是什么类型? (至少选择一个)

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用，不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

其它需要 Reviewer 或社区知晓的内容：

@GitaiQAQ GitaiQAQ changed the base branch from next to master January 21, 2021 06:16
@GitaiQAQ GitaiQAQ changed the base branch from master to next January 21, 2021 06:18
@Chen-jj Chen-jj requested a review from ZakaryCode January 22, 2021 05:53
@Chen-jj Chen-jj added T-h5 Target - 编译到 H5 V-3 Version - 3.x A-components Area - H5 组件库相关 labels Jan 22, 2021
@GitaiQAQ
Copy link
Contributor Author

GitaiQAQ commented Feb 9, 2021

@ZakaryCode @Chen-jj 麻烦大佬 review 一下

ZakaryCode
ZakaryCode approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@ZakaryCode ZakaryCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢贡献

@ZakaryCode ZakaryCode merged commit 64b25cc into NervJS:next Feb 10, 2021
@ZakaryCode ZakaryCode mentioned this pull request Apr 24, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZakaryCode ZakaryCode ZakaryCode approved these changes

Assignees
No one assigned
Labels
A-components Area - H5 组件库相关 T-h5 Target - 编译到 H5 V-3 Version - 3.x
Projects
H5
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GitaiQAQ @ZakaryCode @Chen-jj