Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(taro/types): 事件名仅支持Symbol类型 #7914

Closed
wants to merge 1 commit into from
Closed

fix(taro/types): 事件名仅支持Symbol类型 #7914

wants to merge 1 commit into from

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Oct 25, 2020

这个 PR 做了什么?

修改 @tarojs/taro 中的 Events 类型定义,事件名不支持 Symbol 类型。详见:#7558 (comment)

这个 PR 是什么类型?

  • TypeScript 类型定义修改(Typings)

这个 PR 满足以下需求:

  • 提交到 next分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用,不会影响到其它功能

@SyMind SyMind changed the title fix(taro/types): 事件名不支持Symbol类型 fix(taro/types): 事件名仅支持Symbol类型 Oct 25, 2020
Copy link
Contributor

@ZakaryCode ZakaryCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢贡献

ZakaryCode added a commit that referenced this pull request Nov 16, 2020
@ZakaryCode ZakaryCode mentioned this pull request Nov 16, 2020
20 tasks
@ZakaryCode
Copy link
Contributor

合并分支已经失效,已新建 PR 合并该项

@ZakaryCode ZakaryCode closed this Nov 16, 2020
ZakaryCode added a commit that referenced this pull request Nov 16, 2020
@ZakaryCode ZakaryCode mentioned this pull request Nov 16, 2020
20 tasks
ZakaryCode added a commit that referenced this pull request Nov 16, 2020
ZakaryCode added a commit that referenced this pull request Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants