Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rn): toast #11625

Closed
wants to merge 2 commits into from
Closed

fix(rn): toast #11625

wants to merge 2 commits into from

Conversation

WhiteSean
Copy link
Contributor

这个 PR 做了什么? (简要描述所做更改)
在RN平台调用showToast的api，当icon为‘error’时，界面展示的icon还是success对应的icon,该pr修复该问题，传入error是icon为对应的图标

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

@taro-bot2
Copy link

taro-bot2 bot commented Apr 12, 2022

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献！🌷🌷🌷

一般 PR 会在一到两周内进行 review，成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间，所以请遵循以下规范，协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景（非常重要，例如解决了什么问题，该问题如何复现等）
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通，请加入 Taro 开发者微信群：

@Chen-jj Chen-jj requested a review from zhiqingchen April 12, 2022 14:34
@zhiqingchen zhiqingchen added the T-rn Target - 编译到 React Native label Apr 12, 2022
@zhiqingchen
Copy link
Member

3.4.5-zeta.0

@zhiqingchen zhiqingchen requested a review from iChengbo April 14, 2022 11:19
iChengbo
iChengbo reviewed Apr 15, 2022
View reviewed changes
packages/taro-rn/src/lib/showModal/toast.tsx
width: 42,
height: 42,
marginBottom: 10,
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1、为什么不和 success 一样用 toastIcon？
2、加了 marginBottom，要是没有 title 时，是不是多余？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为success是一个对勾，本身和title之间看起来是有一个间距的，但是error的icon是一个圆形，和title之间没有间距，看起来很丑，这个margin-bottom可以不加，加的目的就是为了好看

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

换个 error icon吧，和 success icon 大小、边距等尽量保持一致。然后也是不需要 margin-bottom

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以的，我找设计师设计一个，换上改一下这个pr

@iChengbo iChengbo changed the title fix: toast fix(rn): toast Apr 15, 2022
@taro-bot2 taro-bot2 bot mentioned this pull request Apr 16, 2022
Closed
@zhiqingchen
Copy link
Member

#11666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iChengbo iChengbo iChengbo left review comments

@zhiqingchen zhiqingchen Awaiting requested review from zhiqingchen

Assignees
No one assigned
Labels
T-rn Target - 编译到 React Native
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WhiteSean @zhiqingchen @iChengbo