Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(h5): 修复textarea在H5端会陷入死循环奔溃的问题 #11443

Merged
merged 5 commits into from
Apr 6, 2022
Merged

fix(h5): 修复textarea在H5端会陷入死循环奔溃的问题 #11443

merged 5 commits into from
Apr 6, 2022

Conversation

rojer95
Copy link
Contributor

@rojer95 rojer95 commented Mar 13, 2022

这个 PR 做了什么? (简要描述所做更改)

textarea 设置了min-height在caculateContentHeight时会陷入死循环

这个 PR 是什么类型? (至少选择一个)

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

@rojer95 rojer95 changed the title fix(h5): textarea caculate content height bug fix(h5): 修复textarea在H5端会陷入死循环奔溃的问题 Mar 13, 2022
@Chen-jj Chen-jj requested a review from ZakaryCode March 14, 2022 13:09
@ZakaryCode ZakaryCode added A-components Area - H5 组件库相关 T-h5 Target - 编译到 H5 labels Mar 15, 2022
@taro-bot2 taro-bot2 bot mentioned this pull request Mar 19, 2022
Closed
ZakaryCode
ZakaryCode approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@ZakaryCode ZakaryCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZakaryCode ZakaryCode added this to the 3.4.6 milestone Apr 6, 2022
@ZakaryCode ZakaryCode modified the milestones: 3.4.6, 3.4.5 Apr 6, 2022
@ZakaryCode ZakaryCode merged commit 1219b0b into NervJS:next Apr 6, 2022
@ZakaryCode ZakaryCode mentioned this pull request Apr 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZakaryCode ZakaryCode ZakaryCode approved these changes

Assignees
No one assigned
Labels
A-components Area - H5 组件库相关 T-h5 Target - 编译到 H5
Projects
H5
Archived in project
Milestone
3.4.5
Development

Successfully merging this pull request may close these issues.
3 participants
@rojer95 @ZakaryCode @Chen-jj