Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mini-runner): @import rule must come first #11246

Merged
merged 11 commits into from
Mar 5, 2022
+53 −11
Merged

fix(mini-runner): @import rule must come first #11246

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
637c9eb
fix(mini-runner): @import rule must come first
noyobo Feb 9, 2022
bc2b8e7
refactor(mini-runner): check for common styles
noyobo Feb 10, 2022
c07dd89
Merge branch 'next' into patch-1
Chen-jj Feb 14, 2022
5e8fc1b
chore(mini-runner): update sourcemap for appStyle
noyobo Feb 15, 2022
b71716f
Merge branch 'next' into patch-1
Chen-jj Feb 16, 2022
1045ceb
test(mini-runner): case rework
noyobo Feb 17, 2022
0815bea
Merge branch 'next' into patch-1
noyobo Feb 17, 2022
5c871b9
Merge branch 'next' into patch-1
noyobo Feb 21, 2022
03dd858
Merge branch 'next' into patch-1
Chen-jj Mar 5, 2022
2ac7074
chore: 把 dev 依赖挪到根目录
Chen-jj Mar 5, 2022
284a609
fix: ci
Chen-jj Mar 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/taro-mini-runner/src/plugins/MiniPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1160,19 +1160,20 @@ export default class TaroMiniPlugin {

const originSource: string = assets[appStyle].source()
const source = new ConcatSource()
source.add(originSource)

Object.keys(assets).forEach(assetName => {
const fileName = path.basename(assetName, path.extname(assetName))
if ((REG_STYLE.test(assetName) || REG_STYLE_EXT.test(assetName)) && this.options.commonChunks.includes(fileName)) {
source.add('\n')
source.add(`@import ${JSON.stringify(urlToRequest(assetName))};`)
assets[appStyle] = {
size: () => source.source().length,
source: () => source.source()
}
source.add('\n')
}
})

source.add(originSource)
noyobo marked this conversation as resolved.
Show resolved Hide resolved
assets[appStyle] = {
size: () => source.source().length,
source: () => source.source()
}
}

addTarBarFilesToDependencies (compilation: webpack.compilation.Compilation) {
Expand Down