Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gulp exists without errors even if a test suite fails. #28

Closed
boljen opened this issue Nov 10, 2016 · 1 comment
Closed

Gulp exists without errors even if a test suite fails. #28

boljen opened this issue Nov 10, 2016 · 1 comment

Comments

@boljen
Copy link
Contributor

boljen commented Nov 10, 2016

In my specific case the test failed because the preprocessor caused an error rather than the actual test code itself.

As it turns out, in some cases a failure is considered a "failed test suite" rather than a "failed test", and these are reported separately.

To fix this, replace this line with:

if(result.numFailedTests || result.numFailedTestSuites) {
@alansouzati
Copy link
Collaborator

are you up to send a pull request to fix this @boljen ?

Thanks for identifying the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants