Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Multiple WW enabled on "change WW intent" #67

Closed
NeonDaniel opened this issue Apr 17, 2023 · 0 comments
Closed

[BUG] Multiple WW enabled on "change WW intent" #67

NeonDaniel opened this issue Apr 17, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@NeonDaniel
Copy link
Member

Description

After changing WW to "hey mycroft", both "hey Mycroft" and "hey Neon" may become active. This is probably because the Mycroft precise model had to be downloaded and the skill timed out waiting for the new WW to activate before deactivating the old WW.

Steps to Reproduce

  • Install a clean Neon image with NeonCore 23.4.4
  • Ask to change wake word to "Mycroft
  • Check if both WW are active

Relevant Code

https://github.com/NeonGeckoCom/skill-device_controls/blob/dev/__init__.py#L260

Other Notes

  • Reported in chat
  • Consider extending timeout to something much longer
  • Consider a method to query WW model availability and do skill processing asynchronously
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant