From e7a13919ff8a8d982290cc1515ef7254ae7a73c8 Mon Sep 17 00:00:00 2001 From: Max Horn Date: Mon, 11 Nov 2024 22:51:39 +0100 Subject: [PATCH] Fix snf_with_transform issue over non-domain See https://github.com/oscar-system/Oscar.jl/issues/4293 --- src/Matrix.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Matrix.jl b/src/Matrix.jl index c45bd6295..d4fd64db3 100644 --- a/src/Matrix.jl +++ b/src/Matrix.jl @@ -5285,7 +5285,7 @@ function snf_kb!(S::MatrixElem{T}, U::MatrixElem{T}, K::MatrixElem{T}, with_traf K[r, j] = reduce!(t1 + t2) end end - S[j, j] = divexact(S[i, i]*S[j, j], d) # FIXME this looks fishy + S[j, j] = S[i, i]*divexact(S[j, j], d) S[i, i] = d end end