Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error handling when miner keys are present but malformed #80

Closed
marvinmarnold opened this issue Aug 25, 2021 · 3 comments
Closed

Better error handling when miner keys are present but malformed #80

marvinmarnold opened this issue Aug 25, 2021 · 3 comments
Labels
needs triage
Milestone
Sprint 1

Comments

@marvinmarnold
Copy link
Contributor

Current behavior is to continue with key values set to False. This allows the program to continue but may result in unexpected behavior. Ideally, we should show an on screen error to the user.

Originated: #69 (comment)
@marvinmarnold marvinmarnold mentioned this issue Aug 25, 2021
Merged
@sentry-io sentry-io bot mentioned this issue Aug 26, 2021
Closed
@vpetersson
Copy link
Contributor

Isn't this replaced by talking directly to the Helium miner API?

@marvinmarnold marvinmarnold added this to the Sprint 1 milestone Aug 26, 2021
@shawaj
Copy link
Member

shawaj commented Aug 28, 2021

@vpetersson in that case it would be if it can't connect to the miner over RPC presumably?

@vpetersson
Copy link
Contributor

We haven't implemented this yet.

@marvinmarnold marvinmarnold mentioned this issue Nov 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs triage
Projects
None yet
Milestone
Sprint 1
Development

No branches or pull requests
4 participants
@vpetersson @marvinmarnold @shawaj @KevinWassermann94