Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct outdoor GPIOs #58

Closed
shawaj opened this issue Aug 10, 2021 · 3 comments · Fixed by #69
Closed

Correct outdoor GPIOs #58

shawaj opened this issue Aug 10, 2021 · 3 comments · Fixed by #69
Assignees
@marvinmarnold

Comments

@shawaj
Copy link
Member

shawaj commented Aug 10, 2021

When we pull in the variant definitions to lib in the new PR that takes over from #54 we need to make sure to update the outdoor units to the correct GPIOs.

See here for variant file https://github.com/NebraLtd/hm-config/blob/marvinmarnold/refactor/lib/variant_definitions.py

Relates to #57 and NebraLtd/hm-pktfwd#31 and NebraLtd/helium-hardware-definitions@577ce0e

FYI @marvinmarnold
@shawaj
Copy link
Member Author

shawaj commented Aug 10, 2021

Essentially outdoor button should be on 24 not 26 on both Outdoor versions

@shawaj
Copy link
Member Author

shawaj commented Aug 12, 2021

Enjoy https://pypi.org/project/hm-hardware-defs/

You want to use v0.1.4

@shawaj shawaj mentioned this issue Aug 12, 2021
Merged
@shawaj
Copy link
Member Author

shawaj commented Aug 24, 2021

Closed by #69

@shawaj shawaj mentioned this issue Aug 24, 2021
Merged
@marvinmarnold marvinmarnold self-assigned this Aug 25, 2021
@shawaj shawaj closed this as completed in #69 Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marvinmarnold marvinmarnold

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support arbitrary APPNAME and correct GPIOs NebraLtd/hm-config
2 participants
@marvinmarnold @shawaj