Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifications for examples in README #49

Open
3 tasks
AndrewDryga opened this issue Jan 23, 2020 · 1 comment
Open
3 tasks

Clarifications for examples in README #49

AndrewDryga opened this issue Jan 23, 2020 · 1 comment

Comments

@AndrewDryga
Copy link
Member

I'll keep this list updated for future readme overhaul:

  • How to act when the side effect is updated (https://elixirforum.com/t/re-sage-sagas-implementation-in-pure-elixir/28498?u=andrewdryga)
  • How and where attrs should be validated so that return struct would look like input? (Ecto.Changeset for all attrs alltogether either before Sage or as one of it's steps, should we add a helper for that?)
  • Avoid using names in functions, keeping them pure (eg. instead of run(:foo, &bar/2) use run(:foo, &bar(&1.fiz, &2)) so that transaction functions are pure and do not depend on each other.
@coladarci
Copy link

A note here to add is that readme also shows incorrect compensation contracts; this tripped a few of us up.. (i.e compensation/3 v compensation/4)

We love this library, btw, thank you for all this work..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants