Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions that return storage prefixes should return &[u8] #93

Open
mooori opened this issue Mar 13, 2023 · 0 comments
Open

Functions that return storage prefixes should return &[u8] #93

mooori opened this issue Mar 13, 2023 · 0 comments

Comments

@mooori
Copy link
Contributor

mooori commented Mar 13, 2023

The functions that return storage prefixes (e.g. Pausable::pa_storage_key) should return &[u8] instead of &'static [u8]. This was pointed out by @birchmd here.

It is a trivial change for all plugins except AccessControllable as described here.

Steps to resolve this issue:

  • Refactor the default implementation of AccessControllable such that acl_storage_prefix can take parameter &self.
  • Change the corresponding functions of all plugins to return &[u8].
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant