Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with running master with Telerik-UI controls - TypeError for listview.js #29

Closed
bradmartin opened this issue Oct 27, 2015 · 5 comments

Comments

@bradmartin
Copy link
Contributor

Downloaded the .zip folder of groceries master then ran 'tns-install', made sure the platform was added, and then 'tns build android'. All went great and I installed the .apk. Everytime I have a successful login it crashes, it has crashed on a device and through appetize.io. The forgot password works as I just received my email.

I've debugged all of the login.js and it gets to the navigate("views/list/list") and crashes everytime. With @tjvantoll credentials and an account I've created.

@bradmartin
Copy link
Contributor Author

I've also added the recyclerview to the build.gradle file, same result.

@bradmartin
Copy link
Contributor Author

I changed the .mainModule = "views/list/list" to determine the cause.

The stacktrace: Cannot read property 'extend' of undefined. Which traces to nativescript-telerik-ui/listview/listview.js:72:3.

Tried removing and adding the platform back in with no luck.

I've copied over a version (working in another app) of telerik-ui into the tns_modules folder to replace the ones from the master branch. This also had no effect with the same results.

Any idea on steps to try and resolve this?

@bradmartin bradmartin changed the title Crashes on successful login - android Issue with running master with Telerik-UI controls - TypeError for listview.js Oct 27, 2015
@tjvantoll
Copy link
Contributor

Hey @bradmartin,

Sorry for the inconvenience. The problem here is probably that the build is not picking up on the build.gradle change. (I say that because I recognize the error.)

Could you try rm -rf platforms/android, tns platform add android, and then adding the line to build.gradle before you run the app for the first time?

We're using Gradle's incremental build feature to speed up builds, but the problem with that is that it occasionally caches things we'd prefer it didn't. Therefore, you have to make sure to add the recyclerview before you do anything else.

Let me know if that works for you. With 1.5 plugins will automatically be able to add lines into the build.gradle file, and this inconvenience should go away.

@bradmartin
Copy link
Contributor Author

@tjvantoll - I didn't even think about caching issue. I'll try that later, now that you mentioned it, that's likely the issue. It's a habit of mine to get projects and just add platform and run without doing anything else. Thanks for the tip and I'll let you know if that fixes the issue later on when I have time to try.

@bradmartin
Copy link
Contributor Author

Nailed it @tjvantoll - thanks for the heads up on the order or those steps being critical with the current version of {N}. Maybe this will save someone some trouble until the next release. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants