Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more unit testing to this sample #103

Open
georgeedwards opened this issue Jun 17, 2016 · 5 comments
Open

Add more unit testing to this sample #103

georgeedwards opened this issue Jun 17, 2016 · 5 comments

Comments

@georgeedwards
Copy link

There doesn't seem to be much info on unit testing Angular2 anywhere, let alone with Nativescript. A practical example would be really helpful, as I have been running into issues trying to do it myself.

@tjvantoll
Copy link
Contributor

Thanks @georgeedwards,

I have the necessary setup in place in this app, see https://github.com/NativeScript/sample-Groceries#unit-testing and https://github.com/NativeScript/sample-Groceries/blob/master/app/tests/shared/user/user.spec.ts, but obviously this is very simplistic. I have more detailed tests on my to-do list, and as always PRs with more tests are welcome 😀

@tjvantoll tjvantoll changed the title ng2 Unit Tests? Add more unit testing to this sample Jan 30, 2017
@tjvantoll
Copy link
Contributor

Just changed the title to better reflect what needs to be done here; we have tests but they’re a bit too simplistic at the moment.

Marking this as a Help Wanted issue, as this would be a great community contribution.

@Roar1827
Copy link

@tjvantoll - I'd love to attempt to help with this, as I want to level up my own understanding in the process. I am unable to get set up in other projects in the same way though, due to #245 . Any ideas?

@tjvantoll
Copy link
Contributor

Hey @Roar1827,

First of all, awesome that you’re looking to contribute here 😄 And #245 is a good question, let me do some asking around. In the meantime you should be able to contribute tests to this repo without needing to go through a full CLI setup.

@Roar1827
Copy link

Hey @tjvantoll , I actually made it past that step I was having trouble with in #245, I will update the issue now.

I've hit some more road blocks, but will continue my work tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants