Fix asset extraction #771
Merged
Fix asset extraction #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n is updated keep the assetsThumb that will not be backed up by the android Auto Backup feature
|
💚 |
vakrilov
approved these changes
May 30, 2017
| return; | ||
| } | ||
|
|
||
| for (File childFile : files) { |
There was a problem hiding this comment.
Isn't there an API to nuke the whole folder at once?
There was a problem hiding this comment.
Not in Java. Java is special! There is a more concise API to work with files, but it isn't available on devices up to Level 23
pkoleva
approved these changes
May 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional logic to asset extraction so that whenever a new version of the application is pushed to the device, at startup the old assets will be wiped out and replaced with those of the new application package.
This will also prevent Android's Auto Backup feature (Android devices level 23 and up) from messing up the application with previously cached scripts, as the changes restored will be removed by the asset extraction mechanism in the runtime.
Also write the assetsThumb, used to check whether assets should be extracted, to a directory that is not backed up, to prevent the thumb from being cached.
Note: scripts and files stored in
context.getFilesDir()/app, those downloaded either from a push plugin, http service, or just stored there, will naturally be removed when the extraction mechanism runs.Addresses issue NativeScript/NativeScript#4137