Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kotlin Object issue #1562

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Fix Kotlin Object issue #1562

merged 1 commit into from
Jan 6, 2020

Conversation

vmutafov
Copy link
Contributor

@vmutafov vmutafov commented Jan 6, 2020

Related to: #1563

Currently, due to an incorrect test, we had regressed the support of Kotlin in the runtime.

Kotlin objects are compiled to a regular class at bytecode level and the special thing about them is a compiler-generated INSTANCE field of the same type as the class.
In a commit included in 6.3.0 we have stripped the INSTANCE field and broken the Kotlin object support.

This PR fixes the issue by gathering the INSTANCE field checking by name and type. There seems to be no way to get information if the currently parsed class is a Kotlin object from the Kotlin metadata.

@cla-bot cla-bot bot added the cla: yes label Jan 6, 2020
@vmutafov vmutafov merged commit ecb25b2 into master Jan 6, 2020
@vmutafov vmutafov deleted the vmutafov/kotlin-object-bug branch January 6, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants