Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JSParser in SBG fail the build when failing #1152

Closed
vtrifonov opened this issue Aug 13, 2018 · 0 comments
Closed

Make JSParser in SBG fail the build when failing #1152

vtrifonov opened this issue Aug 13, 2018 · 0 comments
Assignees
Milestone

Comments

@vtrifonov
Copy link
Contributor

vtrifonov commented Aug 13, 2018

Currently when there's an error when running the JSParser in the Static Binding Generator it fails silently and the build is successful, but no java classes are generated as a result and this would result in ClassNotFound exceptions during runtime. More appropriate behaviour will be making the build fail.

Steps to reproduce:

  1. tns create testApp
  2. add the following row inside createViewModel method in testApp/app/main-view-model.js file: var testList = new java.util.List();
  3. tns run android

Expected: Build should fail showing message that you are not passing enough arguments to extend interface java.util.List
Actual: Message is shown but the build succeeds and the application fails at runtime.

@vtrifonov vtrifonov added this to the 4.3.0 milestone Aug 13, 2018
@vtrifonov vtrifonov self-assigned this Aug 13, 2018
@vtrifonov vtrifonov changed the title Make Static Binding Generator fail the build when failing Make JSParser in SBG fail the build when failing Aug 13, 2018
@vhristov5555 vhristov5555 self-assigned this Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants