Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPC as documented doesn't work #351

Closed
MichelJonkman opened this issue Aug 27, 2024 · 5 comments
Closed

IPC as documented doesn't work #351

MichelJonkman opened this issue Aug 27, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@MichelJonkman
Copy link

What were you trying to do?

Trying to listen to built in and custom events

What happened?

The example in the docs doesn't work

How to reproduce the bug

Copy the example from the docs

Package Versions

Electron 0.7.0, Laravel 0.5.4, Bin 0.4.0

PHP Version

8.3.10

Laravel Version

11.21.0

Node Version

18.18.1

Which operating systems have you seen this occur on?

Windows

OS version

Windows 10

Notes

Links to the relevant docs:
https://nativephp.com/docs/1/digging-deeper/broadcasting#browser-events
https://nativephp.com/docs/1/digging-deeper/broadcasting#javascript

@MichelJonkman MichelJonkman added the bug Something isn't working label Aug 27, 2024
@gwleuverink
Copy link
Contributor

Fixed by #367 @simonhamp?

@MichelJonkman
Copy link
Author

@gwleuverink It looks like it does yeah, maybe a good idea to update the docs as well? The current code on there is incomplete and broken, I can't be the only one confused by it!

@gwleuverink
Copy link
Contributor

Yep that PR is pending release next week 🎉
You can preview the docs here NativePHP/nativephp.com#44

@MichelJonkman
Copy link
Author

Yep that PR is pending release next week 🎉 You can preview the docs here NativePHP/nativephp.com#44

Aaah thank you! Glad to see this getting solved, I just about gave up on NativePHP due to radio silence here and on Discord 😬

I'll close the issue since it's safe to say that it's fixed

@simonhamp
Copy link
Member

@MichelJonkman sorry for missing your messages on Discord 😞

Has been a busy period for me. I'll try to do better.

Thanks to more sponsorships lately I'll have more time for monitoring and replying to tickets and Discord.

Getting there steadily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants