Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: append NBB banner to all code files in the release package #1

Open
christophercr opened this issue Jan 9, 2019 · 1 comment
Labels

Comments

@christophercr
Copy link
Collaborator

christophercr commented Jan 9, 2019

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/ngx-form-errors/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

The code files contained in the final bundle generated after every release don't contain the NBB banner.

Expected behavior

The NBB banner should be present in all code files contained in the release package.

Minimal reproduction of the problem with instructions

Generate a release via the npm run release command

What is the motivation / use case for changing the behavior?

NBB branding

Environment


NgxFormErrors version: 1.0.0-alpha

@christophercr christophercr added enhancement New feature or request comp: all labels Jan 9, 2019
@christophercr
Copy link
Collaborator Author

Apparently this was supported in since versions 2.0.0 and 2.1.0 of ng-packagr but unfortunately this feature was removed in 3.0.0 due to compliance with the new Angular Package Format (APF) v6.0.

So it seems we need to find a way to do this ourselves...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant