Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create Windows executable with this project's icon rather than a generic python application icon #670

Closed
1 task
t52ta6ek opened this issue Aug 3, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@t52ta6ek
Copy link
Contributor

t52ta6ek commented Aug 3, 2023

Feature Request

Allow github action release_win.yml to create a nanovna-saver.exe for Windows containing this project's icon, rather than creating the .exe with a generic python application icon.

Describe Preferred Solution

Describe Alternatives

Related Code

Additional Context

If the feature request is approved, would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)

  • [X ] Yes
  • No
@t52ta6ek t52ta6ek added the enhancement New feature or request label Aug 3, 2023
@zarath zarath marked this as a duplicate of #667 Aug 3, 2023
@zarath zarath closed this as completed Aug 3, 2023
@zarath zarath marked this as not a duplicate of #667 Aug 3, 2023
@zarath zarath reopened this Aug 3, 2023
@zarath
Copy link
Collaborator

zarath commented Aug 3, 2023

I would be happy if binary creation of windows exe in github actions would work again...

@t52ta6ek
Copy link
Contributor Author

t52ta6ek commented Aug 3, 2023 via email

@zarath
Copy link
Collaborator

zarath commented Aug 3, 2023

I've updated python and installer ... now it works again... Windows-Binary added to release...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants