Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user materials when checking for conductivity #689

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Allow user materials when checking for conductivity #689

merged 1 commit into from
Jan 30, 2019

Conversation

ChristopherHogan
Copy link
Contributor

Fixes #687. I'm not sure if the check for MATERIAL_USER was missing for a reason, or if it was just an oversight. With this change, running the script from #687 outputs

flux:, 0.018459, 0.746782, 0.234758
slab is absorbing

@stevengj @oskooi

@ChristopherHogan
Copy link
Contributor Author

Should we also allow MATERIAL_FILE in this case?

@stevengj stevengj merged commit 14a852f into NanoComp:master Jan 30, 2019
@ChristopherHogan ChristopherHogan deleted the chogan/user_cond branch January 30, 2019 19:24
@kannesito kannesito mentioned this pull request May 28, 2019
Open
bencbartlett pushed a commit to bencbartlett/meep that referenced this pull request Sep 9, 2021
@ChristopherHogan @stevengj
Allow user materials when checking for conductivity (NanoComp#689)
65507a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristopherHogan @stevengj