Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add force_all_components #631

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Add force_all_components #631

merged 2 commits into from
Dec 14, 2018

Conversation

ChristopherHogan
Copy link
Contributor

I'm not sure what to add for documentation.
@stevengj @oskooi

@stevengj
Copy link
Collaborator

stevengj commented Dec 11, 2018 •
edited
Loading

Let's change this to a force_all_components constructor flag, and run the require_components code in init_sim. Guard it with if dimensions != 1

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 82.351% when pulling af70b8f on ChristopherHogan:chogan/require_cmpts into 5783225 on stevengj:master.

@ChristopherHogan
Copy link
Contributor Author

Added a force_all_components flag. This is green.

@stevengj stevengj merged commit 333e65e into NanoComp:master Dec 14, 2018
@ChristopherHogan ChristopherHogan deleted the chogan/require_cmpts branch December 14, 2018 16:24
bencbartlett pushed a commit to bencbartlett/meep that referenced this pull request Sep 9, 2021
@ChristopherHogan @stevengj
Add force_all_components (NanoComp#631)
e21d586 
* Add force_all_components

* Change force_all_components to a Simulation constructor flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristopherHogan @stevengj @coveralls