Symmetry in dft arrays #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the presence of symmetries
stevengj
reviewed
Jul 24, 2018
src/dft.cpp
Outdated
| // where NI = number of points in Ith direction. | ||
| int idx2=0; | ||
| for (int i=rank-1, stride=1; i>=0; stride*=array_count[i--]) | ||
| idx2 += stride * iloc.in_direction(ds[i]) / 2; |
There was a problem hiding this comment.
Looks like it should be stride * (iloc.in_direction(ds[i]) / 2)
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
* attempt to handle symmetries in dft arrays * update acquisition of array slices for DFT fields to behave properly in the presence of symmetries * div 2 before stride
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #421.