Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of data files used in gold master tests for unfilter_design #2542

Closed
oskooi opened this issue Jun 6, 2023 · 1 comment · Fixed by #2543
Closed

Reduce size of data files used in gold master tests for unfilter_design #2542

oskooi opened this issue Jun 6, 2023 · 1 comment · Fixed by #2543

Comments

@oskooi
Copy link
Collaborator

oskooi commented Jun 6, 2023

The gold master test for the function unfilter_design of the adjoint-solver module added as part of #2462 involved adding two data files (mpa_unfilter_design.npy and mpa_unfilter_design_target.npy) to the repository which are each 1.3MB in size. The size of these files can likely be reduced considerably without affecting the tests. (Unfortunately, I did not realize how large these files were during the review.)

cc @mochen4

@mochen4
Copy link
Collaborator

mochen4 commented Jun 7, 2023

Thanks! I reduced the size of those files in PR #2543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants